[PATCH] ASoC: qdsp6: Fix an IS_ERR() vs NULL bug

From: Miaoqian Lin
Date: Sat Dec 11 2021 - 01:58:56 EST


The function gpr_alloc_port return ERR_PTR on errors, it doesn't return
null.

Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
---
sound/soc/qcom/qdsp6/q6apm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/qcom/qdsp6/q6apm.c b/sound/soc/qcom/qdsp6/q6apm.c
index 13598ef5bacb..3e007d609a9b 100644
--- a/sound/soc/qcom/qdsp6/q6apm.c
+++ b/sound/soc/qcom/qdsp6/q6apm.c
@@ -630,9 +630,9 @@ struct q6apm_graph *q6apm_graph_open(struct device *dev, q6apm_cb cb,
init_waitqueue_head(&graph->cmd_wait);

graph->port = gpr_alloc_port(apm->gdev, dev, graph_callback, graph);
- if (!graph->port) {
+ if (IS_ERR(graph->port)) {
kfree(graph);
- ret = -ENOMEM;
+ ret = PTR_ERR(graph->port);
goto err;
}

--
2.17.1