Re: [PATCH 08/25] x86/sgx: Make SGX IPI callback available internally

From: Jarkko Sakkinen
Date: Sat Dec 11 2021 - 02:53:26 EST


On Mon, 2021-12-06 at 13:36 -0800, Reinette Chatre wrote:
> Hi Jarkko,
>
> On 12/4/2021 3:00 PM, Jarkko Sakkinen wrote:
> > On Wed, Dec 01, 2021 at 11:23:06AM -0800, Reinette Chatre wrote:
> > > The ETRACK instruction followed by an IPI to all CPUs within an enclave
> > > is a common pattern with more frequent use in support of SGX2.
> > >
> > > Make the (empty) IPI callback function available internally in
> > > preparation for more usages.
> >
> > Please, just describe the usages that this is needed for so that
> > there is zero guesswork required.
>
> The reader is not required to guess. The first paragraph states that
> SGX2 also uses the ETRACK flow that relies on this function. What if I
> replace "for more usages" by "for usage by SGX2"?

I think that'd be good enough.

/Jarkko