[PATCH] nfs: nfs4clinet: check the return value of kstrdup()

From: Xiaoke Wang
Date: Sun Dec 12 2021 - 22:03:56 EST


kstrdup() returns NULL when some internal memory errors happen, it is
better to check the return value of it so to catch the memory error in
time.

Signed-off-by: Xiaoke Wang <xkernel.wang@xxxxxxxxxxx>
---
fs/nfs/nfs4client.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/fs/nfs/nfs4client.c b/fs/nfs/nfs4client.c
index af57332..89f13e0 100644
--- a/fs/nfs/nfs4client.c
+++ b/fs/nfs/nfs4client.c
@@ -1372,5 +1372,8 @@ int nfs4_update_server(struct nfs_server *server, const char *hostname,
server->nfs_client->cl_hostname = kstrdup(hostname, GFP_KERNEL);
nfs_server_insert_lists(server);

+ if (server->nfs_client->cl_hostname == NULL)
+ return -ENOMEM;
+
return nfs_probe_destination(server);
}
--