Re: [PATCH v2] scsi: pm8001: Fix phys_to_virt() usage on dma_addr_t

[John Garry]

On 11/12/2021 00:26, Damien Le Moal wrote:
> > ss
> > @@ -4320,20 +4324,20 @@ static int pm80xx_chip_smp_req(struct pm8001_hba_info *pm8001_ha,
> >   		pm8001_dbg(pm8001_ha, IO, "SMP REQUEST DIRECT MODE\n");
> >   		for (i = 0; i < length; i++)
> >   			if (i < 16) {
> > -				smp_cmd.smp_req16[i] = *(preq_dma_addr+i);
> > +				smp_cmd.smp_req16[i] = *(payload+i);
> Maybe add spacs around the "+" as you did above ?

Yeah, right. I noticed now that only strict mode of checkpatch picks up 
on this.

> >   				pm8001_dbg(pm8001_ha, IO,
> >   					   "Byte[%d]:%x (DMA data:%x)\n",
> >   					   i, smp_cmd.smp_req16[i],

...

> >   	}
> > -
> > +	kunmap_atomic(to);
> >   	build_smp_cmd(pm8001_dev->device_id, smp_cmd.tag,
> >   				&smp_cmd, pm8001_ha->smp_exp_mode, length);
> >   	rc = pm8001_mpi_build_cmd(pm8001_ha, circularQ, opc, &smp_cmd,
> Otherwise, looks OK to me.

cheers