Re: [PATCH v2 8/8] arm64: dts: qcom: add non-secure domain property to fastrpc nodes

[Srinivas Kandagatla]

On 13/12/2021 15:36, Bjorn Andersson wrote:
> On Thu 09 Dec 04:06 PST 2021, Srinivas Kandagatla wrote:
>
> > From: Jeya R <jeyr@xxxxxxxxxxxxxx>
> >
> > FastRPC DSP domain would be set as secure if non-secure dsp property is not
> > added to the fastrpc DT node. Add this property to DT files of msm8916,
> > sdm845, sm8150, sm8250 and sm8350 so that nothing is broken after secure
> > domain patchset.
> >
> > This patch is purely for backward compatibility reasons.
> >
> > Signed-off-by: Jeya R <jeyr@xxxxxxxxxxxxxx>
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/msm8916.dtsi | 1 +
> >   arch/arm64/boot/dts/qcom/sdm845.dtsi  | 2 ++
> >   arch/arm64/boot/dts/qcom/sm8150.dtsi  | 3 +++
> >   arch/arm64/boot/dts/qcom/sm8250.dtsi  | 3 +++
> >   arch/arm64/boot/dts/qcom/sm8350.dtsi  | 3 +++
> >   5 files changed, 12 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> > index c1c42f26b61e..137a479449d4 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> > @@ -1365,6 +1365,7 @@
> >   					compatible = "qcom,fastrpc";
> >   					qcom,smd-channels = "fastrpcsmd-apps-dsp";
> >   					label = "adsp";
> > +					qcom,non-secure-domain;
>
> I was under the impression that the support for loading unsigned fastrpc
> applications was introduced in SM8150 or SM8250, can you confirm that
> this has been possible all along?


Ekansh did confirm that this was introduced from sm8150.


--srini
> Regards,
> Bjorn
>
> >   
> >   					#address-cells = <1>;
> >   					#size-cells = <0>;
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > index 526087586ba4..4aebfed4ec00 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > @@ -838,6 +838,7 @@
> >   				compatible = "qcom,fastrpc";
> >   				qcom,glink-channels = "fastrpcglink-apps-dsp";
> >   				label = "adsp";
> > +				qcom,non-secure-domain;
> >   				#address-cells = <1>;
> >   				#size-cells = <0>;
> >   
> > @@ -888,6 +889,7 @@
> >   				compatible = "qcom,fastrpc";
> >   				qcom,glink-channels = "fastrpcglink-apps-dsp";
> >   				label = "cdsp";
> > +				qcom,non-secure-domain;
> >   				#address-cells = <1>;
> >   				#size-cells = <0>;
> >   
> > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> > index 81b4ff2cc4cd..9ac213bb96b7 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> > @@ -1751,6 +1751,7 @@
> >   					compatible = "qcom,fastrpc";
> >   					qcom,glink-channels = "fastrpcglink-apps-dsp";
> >   					label = "sdsp";
> > +					qcom,non-secure-domain;
> >   					#address-cells = <1>;
> >   					#size-cells = <0>;
> >   
> > @@ -2994,6 +2995,7 @@
> >   					compatible = "qcom,fastrpc";
> >   					qcom,glink-channels = "fastrpcglink-apps-dsp";
> >   					label = "cdsp";
> > +					qcom,non-secure-domain;
> >   					#address-cells = <1>;
> >   					#size-cells = <0>;
> >   
> > @@ -3439,6 +3441,7 @@
> >   					compatible = "qcom,fastrpc";
> >   					qcom,glink-channels = "fastrpcglink-apps-dsp";
> >   					label = "adsp";
> > +					qcom,non-secure-domain;
> >   					#address-cells = <1>;
> >   					#size-cells = <0>;
> >   
> > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> > index f0d342aa662d..06be221ad5b6 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> > @@ -2265,6 +2265,7 @@
> >   					compatible = "qcom,fastrpc";
> >   					qcom,glink-channels = "fastrpcglink-apps-dsp";
> >   					label = "sdsp";
> > +					qcom,non-secure-domain;
> >   					#address-cells = <1>;
> >   					#size-cells = <0>;
> >   
> > @@ -2330,6 +2331,7 @@
> >   					compatible = "qcom,fastrpc";
> >   					qcom,glink-channels = "fastrpcglink-apps-dsp";
> >   					label = "cdsp";
> > +					qcom,non-secure-domain;
> >   					#address-cells = <1>;
> >   					#size-cells = <0>;
> >   
> > @@ -4100,6 +4102,7 @@
> >   					compatible = "qcom,fastrpc";
> >   					qcom,glink-channels = "fastrpcglink-apps-dsp";
> >   					label = "adsp";
> > +					qcom,non-secure-domain;
> >   					#address-cells = <1>;
> >   					#size-cells = <0>;
> >   
> > diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> > index d134280e2939..80f753cbe91c 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> > @@ -1278,6 +1278,7 @@
> >   					compatible = "qcom,fastrpc";
> >   					qcom,glink-channels = "fastrpcglink-apps-dsp";
> >   					label = "sdsp";
> > +					qcom,non-secure-domain;
> >   					#address-cells = <1>;
> >   					#size-cells = <0>;
> >   
> > @@ -1347,6 +1348,7 @@
> >   					compatible = "qcom,fastrpc";
> >   					qcom,glink-channels = "fastrpcglink-apps-dsp";
> >   					label = "cdsp";
> > +					qcom,non-secure-domain;
> >   					#address-cells = <1>;
> >   					#size-cells = <0>;
> >   
> > @@ -1643,6 +1645,7 @@
> >   					compatible = "qcom,fastrpc";
> >   					qcom,glink-channels = "fastrpcglink-apps-dsp";
> >   					label = "adsp";
> > +					qcom,non-secure-domain;
> >   					#address-cells = <1>;
> >   					#size-cells = <0>;
> >   
> > --
> > 2.21.0