Re: [PATCH v2 19/28] iomap: Convert __iomap_zero_iter to use a folio

From: Matthew Wilcox
Date: Mon Dec 13 2021 - 13:08:54 EST


On Sun, Dec 12, 2021 at 11:34:54PM -0800, Christoph Hellwig wrote:
> On Fri, Dec 10, 2021 at 04:19:54PM +0000, Matthew Wilcox wrote:
> > After attempting the merge with Christoph's ill-timed refactoring,
>
> I did give you a headsup before..

I thought that was going in via Darrick's tree. I had no idea Dan was
going to take it.

> > I decided that eliding the use of 'bytes' here was the wrong approach,
> > because it very much needs to be put back in for the merge.
>
> Is there any good reason to not just delay the iomp_zero_iter folio
> conversion for now?

It would hold up about half of the iomap folio conversion (~10 patches).
I don't understand what the benefit is of your patch series. Moving
filesystems away from being bdev based just doesn't seem interesting
to me. Having DAX as an optional feature that some bdevs have seems
like a far superior option.