Re: [PATCH v8 01/40] x86/compressed/64: detect/setup SEV/SME features earlier in boot
From: Borislav Petkov
Date: Mon Dec 13 2021 - 14:17:46 EST
On Mon, Dec 13, 2021 at 01:09:19PM -0600, Venu Busireddy wrote:
> I made this suggestion while reviewing v7 too, but it appears that it
> fell through the cracks. Most of the code in sev_enable() is duplicated
> from sme_enable(). Wouldn't it be better to put all that common code
> in a different function, and call that function from sme_enable()
> and sev_enable()?
How about you look where both functions are defined? Which kernel stages?
And please trim your mails when you reply.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette