RE: [External] : [PATCH for-next v4] RDMA/ocrdma: remove unneeded variable

[Devesh Sharma]

> -----Original Message-----
> From: cgel.zte@xxxxxxxxx <cgel.zte@xxxxxxxxx>
> Sent: Tuesday, December 14, 2021 2:54 PM
> To: Devesh Sharma <devesh.s.sharma@xxxxxxxxxx>
> Cc: cgel.zte@xxxxxxxxx; chi.minghao@xxxxxxxxxx;
> dennis.dalessandro@xxxxxxxxxxxxxxxxxxxx; dledford@xxxxxxxxxx;
> jgg@xxxxxxxx; leon@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> rdma@xxxxxxxxxxxxxxx; mbloch@xxxxxxxxxx; selvin.xavier@xxxxxxxxxxxx;
> trix@xxxxxxxxxx; Zeal Robot <zealci@xxxxxxxxxx>
> Subject: [External] : [PATCH for-next v4] RDMA/ocrdma: remove unneeded
> variable
> 
> From: Minghao Chi <chi.minghao@xxxxxxxxxx>
> 
> Return status directly from function called.
> 
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Minghao Chi <chi.minghao@xxxxxxxxxx>
> ---
> change since v2: [PATCHv2] drivers:ocrdma:remove unneeded variable
>              v3: [PATCH v3 ocrdma-next] drivers: ocrdma: remove unneeded
> variable
>              v4: [PATCH for-next v4] RDMA/ocrdma: remove unneeded variable
> Thanks!
>  drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> index 735123d0e9ec..3bfbf4ec040d 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> @@ -1844,12 +1844,10 @@ int ocrdma_modify_srq(struct ib_srq *ibsrq,
> 
>  int ocrdma_query_srq(struct ib_srq *ibsrq, struct ib_srq_attr
> *srq_attr)
>  {
> -	int status;
>  	struct ocrdma_srq *srq;
> 
>  	srq = get_ocrdma_srq(ibsrq);
> -	status = ocrdma_mbx_query_srq(srq, srq_attr);
> -	return status;
> +	return ocrdma_mbx_query_srq(srq, srq_attr);
>  }
> 
>  int ocrdma_destroy_srq(struct ib_srq *ibsrq, struct ib_udata *udata) @@ -
> 1960,7 +1958,6 @@ static int ocrdma_build_inline_sges(struct ocrdma_qp
> *qp,  static int ocrdma_build_send(struct ocrdma_qp *qp, struct
> ocrdma_hdr_wqe *hdr,
>  			     const struct ib_send_wr *wr)
>  {
> -	int status;
>  	struct ocrdma_sge *sge;
>  	u32 wqe_size = sizeof(*hdr);
> 
> @@ -1972,8 +1969,7 @@ static int ocrdma_build_send(struct ocrdma_qp
> *qp, struct ocrdma_hdr_wqe *hdr,
>  		sge = (struct ocrdma_sge *)(hdr + 1);
>  	}
> 
> -	status = ocrdma_build_inline_sges(qp, hdr, sge, wr, wqe_size);
> -	return status;
> +	return ocrdma_build_inline_sges(qp, hdr, sge, wr, wqe_size);
>  }
> 
>  static int ocrdma_build_write(struct ocrdma_qp *qp, struct
> ocrdma_hdr_wqe *hdr,
LGTM
Reviewed-by: Devesh Sharma <devesh.s.sharma@xxxxxxxxxx>
> --
> 2.25.1