Re: [PATCH -next] selftests: gpio: gpio-sim: avoid forking test twice

From: Andy Shevchenko
Date: Tue Dec 14 2021 - 07:05:05 EST


On Tue, Dec 14, 2021 at 09:09:19AM +0100, Bartosz Golaszewski wrote:
> Use '-o' within [] in order to avoid spawning two processes for test.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Thanks!

> Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Signed-off-by: Bartosz Golaszewski <brgl@xxxxxxxx>
> ---
> tools/testing/selftests/gpio/gpio-sim.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/gpio/gpio-sim.sh b/tools/testing/selftests/gpio/gpio-sim.sh
> index c913d5aec768..341e3de00896 100755
> --- a/tools/testing/selftests/gpio/gpio-sim.sh
> +++ b/tools/testing/selftests/gpio/gpio-sim.sh
> @@ -23,7 +23,7 @@ remove_chip() {
>
> for FILE in $CONFIGFS_DIR/$CHIP/*; do
> BANK=`basename $FILE`
> - if [ "$BANK" = "live" ] || [ "$BANK" = "dev_name" ]; then
> + if [ "$BANK" = "live" -o "$BANK" = "dev_name" ]; then
> continue
> fi
>
> --
> 2.30.1
>

--
With Best Regards,
Andy Shevchenko