Re: [PATCH] coccinelle: adjust the confidence of fen.cocci

[Julia Lawall]

On Tue, 14 Dec 2021, Qing Wang wrote:

> From: Wang Qing <wangqing@xxxxxxxx>
>
> We scan by coccinelle according to the confidence value, then check for
> potential problems. But the accuracy of this cocci is very low,
> the scan results are all wrong.

Can you give some examples of cases where the results are wrong?

thanks,
julia

>
> So, lower its confidence to low.
>
> Signed-off-by: Wang Qing <wangqing@xxxxxxxx>
> ---
>  scripts/coccinelle/iterators/fen.cocci | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coccinelle/iterators/fen.cocci b/scripts/coccinelle/iterators/fen.cocci
> index b69f966..7b71207
> --- a/scripts/coccinelle/iterators/fen.cocci
> +++ b/scripts/coccinelle/iterators/fen.cocci
> @@ -2,7 +2,7 @@
>  /// These iterators only exit normally when the loop cursor is NULL, so there
>  /// is no point to call of_node_put on the final value.
>  ///
> -// Confidence: High
> +// Confidence: Low
>  // Copyright: (C) 2010-2012 Nicolas Palix.
>  // Copyright: (C) 2010-2012 Julia Lawall, INRIA/LIP6.
>  // Copyright: (C) 2010-2012 Gilles Muller, INRIA/LiP6.
> --
> 2.7.4
>
>