Re: [PATCH] phy: freescale: pcie: explictly add bitfield.h

[Vinod Koul]

On 15-12-21, 06:29, Hongxing Zhu wrote:
> > -----Original Message-----
> > From: Vinod Koul <vkoul@xxxxxxxxxx>
> > Sent: Wednesday, December 15, 2021 2:09 PM
> > To: Kishon Vijay Abraham I <kishon@xxxxxx>; Hongxing Zhu
> > <hongxing.zhu@xxxxxxx>
> > Cc: linux-phy@xxxxxxxxxxxxxxxxxxx; Vinod Koul <vkoul@xxxxxxxxxx>;
> > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > kernel test robot <lkp@xxxxxxxxx>
> > Subject: [PATCH] phy: freescale: pcie: explictly add bitfield.h
> > 
> > kernel test robot complains about missing FIELD_PREP, so include
> > bitfield.h for that
> > 
> > drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit
> > declaration of function 'FIELD_PREP'
> > [-Werror=implicit-function-declaration]
> > drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit
> > declaration of function 'FIELD_PREP'
> > [-Werror=implicit-function-declaration]
> > 
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie
> > standalone phy driver")
> > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
> Reviewed-by: Richard Zhu <hongxing.zhu@xxxxxxx>

Thanks for quick review, I have pushed this

> Thanks a lot for your help to fix it.
> And I'm sorry about that I didn't capture this error in my local build and tests.

No worries, Do test on different arch's other than yours

-- 
~Vinod