Re: [PATCH] drm/msm: Don't use autosuspend for display

From: Dmitry Baryshkov
Date: Wed Dec 15 2021 - 14:17:02 EST


On Wed, 15 Dec 2021 at 22:10, Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
>
> Quoting Rob Clark (2021-12-15 09:59:02)
> > From: Rob Clark <robdclark@xxxxxxxxxxxx>
> >
> > No functional change, as we only actually enable autosuspend for the GPU
> > device. But lets not encourage thinking that autosuspend is a good idea
> > for anything display related.
>
> I'd prefer to see a small blurb about why it's not a good idea to use
> autosuspend for display things. Then this commit can be dug out of the
> history and someone new can quickly understand the reasoning behind it.
> Just saying it's not a good idea doesn't really help.

I'd second this request, Nevertheless
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

>
> >
> > Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx>
> > ---
>
> Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>



--
With best wishes
Dmitry