Re: [PATCH v11 04/15] iio: afe: rescale: expose scale processing function
From: Andy Shevchenko
Date: Wed Dec 22 2021 - 05:21:42 EST
On Wed, Dec 22, 2021 at 5:46 AM Liam Beguin <liambeguin@xxxxxxxxx> wrote:
>
> From: Liam Beguin <lvb@xxxxxxxxxx>
>
> In preparation for the addition of kunit tests, expose the logic
> responsible for combining channel scales.
...
> #include <linux/gcd.h>
> #include <linux/iio/consumer.h>
> #include <linux/iio/iio.h>
> +#include <linux/iio/afe/rescale.h>
It should go before the consumer.h, no?
And I would rather move the entire IIO group of headers...
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/property.h>
... somewhere here (with blank line above).
>
> -struct rescale;
...
> +#ifndef __IIO_RESCALE_H__
> +#define __IIO_RESCALE_H__
> +
> +#include <linux/iio/iio.h>
Missed types.h and forward declarations like
struct device;
--
With Best Regards,
Andy Shevchenko