Re: [PATCH 0/4] mfd: intel_soc_pmic_crc: Add crystal_cove_charger cell

[Andy Shevchenko]

On Sat, Dec 25, 2021 at 1:55 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> Hi All,
>
> While doing a hobby project getting the mainline kernel to work on some
> x86 tablets which come with Android pre-installed and which clearly have
> never been meant to run Windows (or another generic OS) I encountered an
> interesting setup for the bq24190 charger chip IRQ, it is not connected
> to the main Bay Trail SoC, instead it runs through a special
> external-charger IRQ pin on the CRC PMIC.
>
> This series adds support for that.

FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

There are a few non-showstopper comments, though.

> Lee, patch 4/4 is included mostly FYI. It depends on current pdx86/for-next
> and I plan to merge it through the pdx86 tree.
>
> Patches 1-3 can be merged through the MFD tree indepdently.
>
> Regards,
>
> Hans
>
>
> Hans de Goede (4):
>   mfd: intel_soc_pmic_crc: Sort cells by IRQ order
>   mfd: intel_soc_pmic_crc: Add crystal_cove_charger cell to BYT cells
>   mfd: intel_soc_pmic_crc: Set main IRQ domain bus token to
>     DOMAIN_BUS_NEXUS
>   platform/x86: Add crystal_cove_charger driver
>
>  drivers/mfd/intel_soc_pmic_core.c           |   4 +
>  drivers/mfd/intel_soc_pmic_crc.c            |  35 +++--
>  drivers/platform/x86/Makefile               |   2 +-
>  drivers/platform/x86/crystal_cove_charger.c | 153 ++++++++++++++++++++
>  4 files changed, 180 insertions(+), 14 deletions(-)
>  create mode 100644 drivers/platform/x86/crystal_cove_charger.c
>
> --
> 2.33.1
>


-- 
With Best Regards,
Andy Shevchenko