Re: [PATCH resend] uapi: fix linux/nfc.h userspace compilation errors

From: Krzysztof Kozlowski
Date: Sun Dec 26 2021 - 06:48:07 EST


On 26/12/2021 00:42, Dmitry V. Levin wrote:
> Replace sa_family_t with __kernel_sa_family_t to fix the following
> linux/nfc.h userspace compilation errors:
>
> /usr/include/linux/nfc.h:266:2: error: unknown type name 'sa_family_t'
> sa_family_t sa_family;
> /usr/include/linux/nfc.h:274:2: error: unknown type name 'sa_family_t'
> sa_family_t sa_family;
>
> Link: https://lore.kernel.org/lkml/20170220181613.GB11185@xxxxxxxxxxxx/

Please skip the link. There will be link added for current patch which
leads to this discussion. There was no discussion in 2017.

> Signed-off-by: Dmitry V. Levin <ldv@xxxxxxxxxxxx>
> ---
> The patch was submitted almost 5 years ago, and I was under impression
> that it was applied among others of this kind, but, apparently,
> it's still relevant.
>
> include/uapi/linux/nfc.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/linux/nfc.h b/include/uapi/linux/nfc.h
> index f6e3c8c9c744..aadad43d943a 100644
> --- a/include/uapi/linux/nfc.h
> +++ b/include/uapi/linux/nfc.h
> @@ -263,7 +263,7 @@ enum nfc_sdp_attr {
> #define NFC_SE_ENABLED 0x1
>
> struct sockaddr_nfc {
> - sa_family_t sa_family;
> + __kernel_sa_family_t sa_family;

include/uapi/linux/nfc.h includes linux/socket.h which defines typedef:
__kernel_sa_family_t sa_family_t;
so how exactly the build is being fixed? How to reproduce it?

Best regards,
Krzysztof