Re: [RFC 01/32] Kconfig: introduce and depend on LEGACY_PCI
From: Greg Kroah-Hartman
Date: Tue Dec 28 2021 - 03:21:39 EST
On Mon, Dec 27, 2021 at 05:42:46PM +0100, Niklas Schnelle wrote:
> --- a/drivers/pci/Kconfig
> +++ b/drivers/pci/Kconfig
> @@ -23,6 +23,17 @@ menuconfig PCI
>
> if PCI
>
> +config LEGACY_PCI
> + bool "Enable support for legacy PCI devices"
> + depends on HAVE_PCI
> + help
> + This option enables support for legacy PCI devices. This includes
> + PCI devices attached directly or via a bridge on a PCI Express bus.
> + It also includes compatibility features on PCI Express devices which
> + make use of legacy I/O spaces.
All you really care about is the "legacy" I/O spaces here, this isn't
tied to PCI specifically at all, right?
So why not just have a OLD_STYLE_IO config option or something like
that, to show that it's the i/o functions we care about here, not PCI at
all?
And maybe not call it "old" or "legacy" as time constantly goes forward,
just describe it as it is, "DIRECT_IO"?
thanks,
greg k-h