Re: [PATCH] dt-bindings: mfd: convert to yaml Qualcomm SPMI PMIC
From: Lee Jones
Date: Wed Dec 29 2021 - 05:20:25 EST
On Wed, 29 Dec 2021, Caleb Connolly wrote:
> On Wed, 29 Dec 2021, 09:48 Lee Jones, <lee.jones@xxxxxxxxxx> wrote:
>
> > On Mon, 27 Dec 2021, David Heidelberg wrote:
> >
> > > From: Caleb Connolly <caleb.connolly@xxxxxxxxxx>
> > >
> > > Convert Qualcomm SPMI PMIC binding to yaml format.
> > >
> > > Additional changes:
> > > - filled many missing compatibles
> > >
> > > Co-developed-by: David Heidelberg <david@xxxxxxx>
> > > Signed-off-by: David Heidelberg <david@xxxxxxx>
> >
> > I must admit, I'm a bit hazy on the details, but this looks odd to
> > me. Shouldn't this have Caleb's SoB too? Also, if you apply your
> > SoB, I'm not sure you also need to apply a CDB as well?
> >
> Yeah, this should not be from me, I did originally work on this patch but
> wasn't able to finish it. David perhaps resend with yourself as the patch
> author and add
> Co-developed-by: Caleb Connolly <caleb@xxxxxxxxxxxxx>
That would make more sense.
> (either way, it shouldn't have been authored by my @linaro.org email
> address).
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog