Re: [Resource Leak] Missing closing files in testing/selftests/vm/mlock2

[Andrew Morton]

On Thu, 30 Dec 2021 11:17:37 +0800 Ryan Cai <ycaibb@xxxxxxxxx> wrote:

> Dear Kernel maintainers,
>               1. In testing/selftests/vm/mlock2, the file opened at Line 39 may not closed when going to Line 65.
>               Location: https://github.com/torvalds/linux/blob/5bfc75d92efd494db37f5c4c173d3639d4772966/tools/testing/selftests/vm/mlock2.h#L37-L49

That's what exit() does.  I don't think we really care unless the leak
is inside a loop.

That being said, it's untidy and is setting a poor example so I guess
we should fix it.

>               Can I send I a patch?

It would be better to just send the patch rather than preceding it
with "can I send a patch".  Everyone can send a patch and they are
encouraged to do so!