Re: mmotm 2021-12-29-20-07 uploaded (mm/damon)

[Randy Dunlap]

On 12/29/21 22:33, Baolin Wang wrote:
> Hi,
> 
> On 12/30/2021 2:27 PM, Randy Dunlap wrote:
>> Hi--
>>
>> On 12/29/21 20:07, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
>>> The mm-of-the-moment snapshot 2021-12-29-20-07 has been uploaded to
>>>
>>>     https://www.ozlabs.org/~akpm/mmotm/
>>>
>>> mmotm-readme.txt says
>>>
>>> README for mm-of-the-moment:
>>>
>>> https://www.ozlabs.org/~akpm/mmotm/
>>>
>>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
>>> more than once a week.
>>>
>>> You will need quilt to apply these patches to the latest Linus release (5.x
>>> or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in
>>> https://ozlabs.org/~akpm/mmotm/series
>>>
>>> The file broken-out.tar.gz contains two datestamp files: .DATE and
>>> .DATE-yyyy-mm-dd-hh-mm-ss.  Both contain the string yyyy-mm-dd-hh-mm-ss,
>>> followed by the base kernel version against which this patch series is to
>>> be applied.
>>
>>
>> On i386:
>>
>> ../mm/damon/vaddr.c: In function ‘damon_hugetlb_mkold’:
>> ../mm/damon/vaddr.c:402:17: warning: unused variable ‘h’ [-Wunused-variable]
>>    struct hstate *h = hstate_vma(vma);
> 
> Ah, thanks for report, I think below changes can fix the warning. And I'll send a new version to address this warning.

Yes, that works. Thanks.

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested

> diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c
> index bcdc602..25bff8a 100644
> --- a/mm/damon/vaddr.c
> +++ b/mm/damon/vaddr.c
> @@ -397,7 +397,6 @@ static void damon_hugetlb_mkold(pte_t *pte, struct mm_struct *mm,
>                                 struct vm_area_struct *vma, unsigned long addr)
>  {
>         bool referenced = false;
> -       struct hstate *h = hstate_vma(vma);
>         pte_t entry = huge_ptep_get(pte);
>         struct page *page = pte_page(entry);
> 
> @@ -414,7 +413,7 @@ static void damon_hugetlb_mkold(pte_t *pte, struct mm_struct *mm,
>         }
> 
>  #ifdef CONFIG_MMU_NOTIFIER
> -       if (mmu_notifier_clear_young(mm, addr, addr + huge_page_size(h)))
> +       if (mmu_notifier_clear_young(mm, addr, addr + huge_page_size(hstate_vma(vma))))
>                 referenced = true;
>  #endif /* CONFIG_MMU_NOTIFIER */

-- 
~Randy