[dlemoal-libata:for-5.17-logging 31/79] drivers/ata/sata_fsl.c:316:17: error: passing argument 2 of '__dynamic_dev_dbg' from incompatible pointer type

From: kernel test robot
Date: Fri Dec 31 2021 - 11:20:35 EST

Next message: Krzysztof Kozlowski: "[PATCH 01/24] pinctrl: samsung: drop pin banks references on error paths"
Previous message: Hangyu Hua: "Re: [PATCH v3 2/2] usb: gadget: clear related members when goto fail"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

tree: git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata.git for-5.17-logging
head: fc730a4198504b83666da816eea7cb582fd9ae01
commit: 8bb1beeb144d8284af32b98c9f46f58030b74ac2 [31/79] sata_fsl: move DPRINTK to ata debugging
config: powerpc64-randconfig-r036-20211231 (https://download.01.org/0day-ci/archive/20220101/202201010008.hPfgdpH7-lkp@xxxxxxxxx/config)
compiler: powerpc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata.git/commit/?id=8bb1beeb144d8284af32b98c9f46f58030b74ac2
git remote add dlemoal-libata git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata.git
git fetch --no-tags dlemoal-libata for-5.17-logging
git checkout 8bb1beeb144d8284af32b98c9f46f58030b74ac2
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

In file included from include/linux/printk.h:559,
from include/linux/kernel.h:20,
from drivers/ata/sata_fsl.c:13:
drivers/ata/sata_fsl.c: In function 'fsl_sata_set_irq_coalescing':
>> drivers/ata/sata_fsl.c:316:17: error: passing argument 2 of '__dynamic_dev_dbg' from incompatible pointer type [-Werror=incompatible-pointer-types]
316 | dev_dbg(&host->dev, "interrupt coalescing, count = 0x%x, ticks = %x\n",
| ^~~~~~~~~~
| |
| struct device **
include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
134 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:166:9: note: in expansion of macro '_dynamic_func_call'
166 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/ata/sata_fsl.c:316:9: note: in expansion of macro 'dev_dbg'
316 | dev_dbg(&host->dev, "interrupt coalescing, count = 0x%x, ticks = %x\n",
| ^~~~~~~
include/linux/dynamic_debug.h:73:73: note: expected 'const struct device *' but argument is of type 'struct device **'
73 | void __dynamic_dev_dbg(struct _ddebug *descriptor, const struct device *dev,
| ~~~~~~~~~~~~~~~~~~~~~^~~
drivers/ata/sata_fsl.c:318:17: error: passing argument 2 of '__dynamic_dev_dbg' from incompatible pointer type [-Werror=incompatible-pointer-types]
318 | dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
| ^~~~~~~~~~
| |
| struct device **
include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
134 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:166:9: note: in expansion of macro '_dynamic_func_call'
166 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/ata/sata_fsl.c:318:9: note: in expansion of macro 'dev_dbg'
318 | dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
| ^~~~~~~
include/linux/dynamic_debug.h:73:73: note: expected 'const struct device *' but argument is of type 'struct device **'
73 | void __dynamic_dev_dbg(struct _ddebug *descriptor, const struct device *dev,
| ~~~~~~~~~~~~~~~~~~~~~^~~
drivers/ata/sata_fsl.c:318:29: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'void *' [-Wformat=]
318 | dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
134 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:166:9: note: in expansion of macro '_dynamic_func_call'
166 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:30: note: in expansion of macro 'dev_fmt'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/ata/sata_fsl.c:318:9: note: in expansion of macro 'dev_dbg'
318 | dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
| ^~~~~~~
drivers/ata/sata_fsl.c:318:65: note: format string is defined here
318 | dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
| ~^
| |
| unsigned int
| %p
In file included from include/linux/printk.h:559,
from include/linux/kernel.h:20,
from drivers/ata/sata_fsl.c:13:
drivers/ata/sata_fsl.c: In function 'sata_fsl_init_controller':
drivers/ata/sata_fsl.c:1361:22: error: 'ap' undeclared (first use in this function); did you mean 'up'?
1361 | ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
| ^~
include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
134 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:162:9: note: in expansion of macro '_dynamic_func_call'
162 | _dynamic_func_call(fmt, __dynamic_pr_debug, \
| ^~~~~~~~~~~~~~~~~~
include/linux/printk.h:574:9: note: in expansion of macro 'dynamic_pr_debug'
574 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~
include/linux/libata.h:1493:9: note: in expansion of macro 'pr_debug'
1493 | pr_ ## level ("ata%u: " fmt, (ap)->print_id, ##__VA_ARGS__)
| ^~~
include/linux/libata.h:1504:9: note: in expansion of macro 'ata_port_printk'
1504 | ata_port_printk(debug, ap, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/ata/sata_fsl.c:1361:9: note: in expansion of macro 'ata_port_dbg'
1361 | ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
| ^~~~~~~~~~~~
drivers/ata/sata_fsl.c:1361:22: note: each undeclared identifier is reported only once for each function it appears in
1361 | ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
| ^~
include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
134 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:162:9: note: in expansion of macro '_dynamic_func_call'
162 | _dynamic_func_call(fmt, __dynamic_pr_debug, \
| ^~~~~~~~~~~~~~~~~~
include/linux/printk.h:574:9: note: in expansion of macro 'dynamic_pr_debug'
574 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~

vim +/__dynamic_dev_dbg +316 drivers/ata/sata_fsl.c

290
291 static void fsl_sata_set_irq_coalescing(struct ata_host *host,
292 unsigned int count, unsigned int ticks)
293 {
294 struct sata_fsl_host_priv *host_priv = host->private_data;
295 void __iomem *hcr_base = host_priv->hcr_base;
296 unsigned long flags;
297
298 if (count > ICC_MAX_INT_COUNT_THRESHOLD)
299 count = ICC_MAX_INT_COUNT_THRESHOLD;
300 else if (count < ICC_MIN_INT_COUNT_THRESHOLD)
301 count = ICC_MIN_INT_COUNT_THRESHOLD;
302
303 if (ticks > ICC_MAX_INT_TICKS_THRESHOLD)
304 ticks = ICC_MAX_INT_TICKS_THRESHOLD;
305 else if ((ICC_MIN_INT_TICKS_THRESHOLD == ticks) &&
306 (count > ICC_MIN_INT_COUNT_THRESHOLD))
307 ticks = ICC_SAFE_INT_TICKS;
308
309 spin_lock_irqsave(&host->lock, flags);
310 iowrite32((count << 24 | ticks), hcr_base + ICC);
311
312 intr_coalescing_count = count;
313 intr_coalescing_ticks = ticks;
314 spin_unlock_irqrestore(&host->lock, flags);
315
> 316 dev_dbg(&host->dev, "interrupt coalescing, count = 0x%x, ticks = %x\n",
317 intr_coalescing_count, intr_coalescing_ticks);
318 dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
319 hcr_base, ioread32(hcr_base + ICC));
320 }
321

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Next message: Krzysztof Kozlowski: "[PATCH 01/24] pinctrl: samsung: drop pin banks references on error paths"
Previous message: Hangyu Hua: "Re: [PATCH v3 2/2] usb: gadget: clear related members when goto fail"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]