Re: [PATCH] iio: gyro: bmg160: Fix error handling in bmg160_core_probe
From: Andy Shevchenko
Date: Wed Jan 05 2022 - 09:21:23 EST
On Wed, Jan 05, 2022 at 12:56:30PM +0000, Miaoqian Lin wrote:
> The pm_runtime_enable will increase power disable depth.
> If the probe fails, we should use pm_runtime_disable() to balance
> pm_runtime_enable(). In the PM Runtime docs:
> Drivers in ->remove() callback should undo the runtime PM changes done
> in ->probe(). Usually this means calling pm_runtime_disable(),
> pm_runtime_dont_use_autosuspend() etc.
> We should do this in error handling.
Looking into culprit commit, can you fix all of them, please?
--
With Best Regards,
Andy Shevchenko