Re: [PATCH] net/mlx5e: Fix missing error code in mlx5e_rx_reporter_err_icosq_cqe_recover()

[Saeed Mahameed]

On Wed, Jan 05, 2022 at 11:17:51PM +0800, Jiapeng Chong wrote:
> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'err'.
>
> Eliminate the follow smatch warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c:91
> mlx5e_rx_reporter_err_icosq_cqe_recover() warn: missing error code
> 'err'.

error code is not missing, err is equal to 0 at this point and the 
code aborts with err = 0 as intended. False alarm. nack.