Re: [PATCH v2 10/35] brcmfmac: firmware: Allow platform to override macaddr

From: Arend van Spriel
Date: Sat Jan 08 2022 - 15:15:14 EST


On 1/4/2022 8:26 AM, Hector Martin wrote:
On Device Tree platforms, it is customary to be able to set the MAC
address via the Device Tree, as it is often stored in system firmware.
This is particularly relevant for Apple ARM64 platforms, where this
information comes from system configuration and passed through by the
bootloader into the DT.

Implement support for this by fetching the platform MAC address and
adding or replacing the macaddr= property in nvram. This becomes the
dongle's default MAC address.

On platforms with an SROM MAC address, this overrides it. On platforms
without one, such as Apple ARM64 devices, this is required for the
firmware to boot (it will fail if it does not have a valid MAC at all).

What overrides what. Can you elaborate a bit?

Reviewed-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Signed-off-by: Hector Martin <marcan@xxxxxxxxx>
---
.../broadcom/brcm80211/brcmfmac/firmware.c | 29 +++++++++++++++++--
1 file changed, 27 insertions(+), 2 deletions(-)

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature