Re: [PATCH v9 3/3] mmc: Add driver for LiteX's LiteSDCard interface

From: Gabriel L. Somlo
Date: Sat Jan 08 2022 - 23:19:30 EST


On Sun, Jan 09, 2022 at 10:50:42AM +0800, Hillf Danton wrote:
> On Sat, 8 Jan 2022 11:11:34 -0500 Gabriel Somlo wrote:
> > +
> > + /* LiteSDCard can support 64-bit DMA addressing */
> > + ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
> > + if (ret)
> > + return ret;
> > +
> > + host->buf_size = mmc->max_req_size * 2;
> > + host->buffer = dmam_alloc_coherent(dev, host->buf_size,
> > + &host->dma, GFP_DMA);
>
> GFP_DMA can not make much sence given the above comment.

I'll change it to GFP_KERNEL in v10. Thanks for catching that,
--Gabriel