Re: [PATCH v2 05/28] gup: Change the calling convention for compound_next()

From: Christoph Hellwig
Date: Mon Jan 10 2022 - 03:28:29 EST

Next message: Yu Tu: "[PATCH] tty: serial: meson: meson_uart_shutdown omit clear AML_UART_TX_EN bit"
Previous message: Yu Tu: "[PATCH] tty: serial: meson: Make the bit24 and bit [26,27] of the UART_REG5 register writable"
In reply to: Matthew Wilcox (Oracle): "[PATCH v2 05/28] gup: Change the calling convention for compound_next()"
Next in thread: Matthew Wilcox: "Re: [PATCH v2 05/28] gup: Change the calling convention for compound_next()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Mon, Jan 10, 2022 at 04:23:43AM +0000, Matthew Wilcox (Oracle) wrote:
> Return the head page instead of storing it to a passed parameter.

Looks good, but same comment about maybe passing list and npages first.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Next message: Yu Tu: "[PATCH] tty: serial: meson: meson_uart_shutdown omit clear AML_UART_TX_EN bit"
Previous message: Yu Tu: "[PATCH] tty: serial: meson: Make the bit24 and bit [26,27] of the UART_REG5 register writable"
In reply to: Matthew Wilcox (Oracle): "[PATCH v2 05/28] gup: Change the calling convention for compound_next()"
Next in thread: Matthew Wilcox: "Re: [PATCH v2 05/28] gup: Change the calling convention for compound_next()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]