Re: [PATCH v2 17/35] brcmfmac: pcie: Provide a buffer of random bytes to the device

[Arend van Spriel]

On 1/4/2022 8:26 AM, Hector Martin wrote:
> Newer Apple firmwares on chipsets without a hardware RNG require the
> host to provide a buffer of 256 random bytes to the device on
> initialization. This buffer is present immediately before NVRAM,
> suffixed by a footer containing a magic number and the buffer length.
>
> This won't affect chips/firmwares that do not use this feature, so do it
> unconditionally.

Not sure what the general opinion is here, but pulling random bytes for 
naught seems wasteful to me. So if there is a way of knowing it is 
needed please make it conditional.

Reviewed-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Signed-off-by: Hector Martin <marcan@xxxxxxxxx>
> ---
>   .../broadcom/brcm80211/brcmfmac/pcie.c        | 30 +++++++++++++++++++
>   1 file changed, 30 insertions(+)

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature