Re: [PATCH v2 00/35] brcmfmac: Support Apple T2 and M1 platforms

[Hector Martin]

On 2022/01/10 19:14, Kalle Valo wrote:
> Hector Martin <marcan@xxxxxxxxx> writes:
> 
>> Hi everyone,
>>
>> Happy new year! This 35-patch series adds proper support for the
>> Broadcom FullMAC chips used on Apple T2 and M1 platforms:
>>
>> - BCM4355C1
>> - BCM4364B2/B3
>> - BCM4377B3
>> - BCM4378B1
>> - BCM4387C2
> 
> 35 patches is a lot to review. It would make things easier for reviewers
> if you can split this into smaller patchsets, 10-12 patches per set is
> what I usually recommend. More info in the wiki link below.

The patches are already split into logical groupings, so I think there
isn't much more to be gained by sending them separately. As I described
in the cover letter:

01~09: Firmware selection stuff
10~14: Add support for BCM4378
15~20: Add BCM4355/4364/4377 on top
21~27: Add BCM4387 and its newer requirements
28~32: Misc fixes
33~35: TxCap & calibration support

If you want to review the series piecemeal, feel free to stop at any of
those boundaries; the series will still make sense and is useful at any
of those stopping points.

Note that the firmware selection stuff (in particular patches #4 and #6)
will change quite a bit in v3 from the review feedback so far, so you
might want to skip reviewing those in detail for v2.

-- 
Hector Martin (marcan@xxxxxxxxx)
Public Key: https://mrcn.st/pub