Re: [PATCH v2 3/5] iommu/mediatek: Remove the power status checking in tlb flush all

[AngeloGioacchino Del Regno]

Il 08/12/21 13:07, Dafna Hirschfeld ha scritto:
> From: Yong Wu <yong.wu@xxxxxxxxxxxx>
>
> To simplify the code, Remove the power status checking in the
> tlb_flush_all, remove this:
>     if (pm_runtime_get_if_in_use(data->dev) <= 0)
> 	    continue;
>
> The mtk_iommu_tlb_flush_all is called from
> a) isr
> b) tlb flush range fail case
> c) iommu_create_device_direct_mappings
>
> In first two cases, the power and clock are always enabled.
> In the third case tlb flush is unnecessary because in a later patch
> in the series a full flush from the pm_runtime_resume callback is added.
>
> In addition, writing the tlb control register when the iommu is not resumed
> is ok and the write is ignored.
>
> Signed-off-by: Yong Wu <yong.wu@xxxxxxxxxxxx>
> [refactor commit log]
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>