Re: [PATCH v3 1/2] m68k: add asm/config.h

[Laurent Vivier]

Le 10/01/2022 à 15:21, Geert Uytterhoeven a écrit :
> Hi Laurent,
>
> On Mon, Jan 10, 2022 at 9:42 AM Laurent Vivier <laurent@xxxxxxxxx> wrote:
> > To avoid 'warning: no previous prototype for' error, declare all
> > the parse_bootinfo and config functions prototypes into asm/config.h
> > and include it in arch/m68k/kernel/setup_mm.c and arch/m68k/*/config.c
> >
> > Signed-off-by: Laurent Vivier <laurent@xxxxxxxxx>
>
> Thanks for your patch!
>
> > --- /dev/null
> > +++ b/arch/m68k/include/asm/config.h
> > @@ -0,0 +1,33 @@
> > +// SPDX-License-Identifier: GPL-2.0
>
> scripts/checkpatch.pl says this is the wrong one.

I'm going to add a pre-commit git hook to run checkpatch.pl in the future...

> > +
> > +/*
> > + * This file contains prototypes provided by each m68k machine
> > + * to parse bootinfo datastructure and to configure the machine
>
> data structures
>
> > + */
> > +
> > +#ifndef _M68K_CONFIG_H
> > +#define _M68K_CONFIG_H
> > +
> > +extern int amiga_parse_bootinfo(const struct bi_record *);
> > +extern int atari_parse_bootinfo(const struct bi_record *);
> > +extern int mac_parse_bootinfo(const struct bi_record *);
> > +extern int q40_parse_bootinfo(const struct bi_record *);
> > +extern int bvme6000_parse_bootinfo(const struct bi_record *);
> > +extern int mvme16x_parse_bootinfo(const struct bi_record *);
> > +extern int mvme147_parse_bootinfo(const struct bi_record *);
> > +extern int hp300_parse_bootinfo(const struct bi_record *);
> > +extern int apollo_parse_bootinfo(const struct bi_record *);
>
> Missing parameter names.
>
> I can fix those while applying.

Please, do.

> Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> i.e. will queue in the m68k for-v5.18 branch.
>
> Gr{oetje,eeting}s,
>
>                          Geert

Thanks,
Laurent