Re: [PATCH 1/3] staging: most: dim2: update renesas compatible string

From: Geert Uytterhoeven
Date: Mon Jan 10 2022 - 10:58:38 EST


Hi Nikita,

On Sun, Dec 26, 2021 at 9:25 AM Nikita Yushchenko
<nikita.yoush@xxxxxxxxxxxxxxxxxx> wrote:
> Use "renesas,rcar-gen3-mlp" instead of "rcar,medialb-dim2"
> - the documented vendor prefix for Renesas is "renesas,"
> - existing r-car devices use "rcar-genN-XXX" pattern.
>
> There are currently no in-tree users to update.
>
> Signed-off-by: Nikita Yushchenko <nikita.yoush@xxxxxxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/staging/most/dim2/dim2.c
> +++ b/drivers/staging/most/dim2/dim2.c
> @@ -1086,7 +1086,7 @@ static const struct of_device_id dim2_of_match[] = {
> .data = plat_data + RCAR_H2
> },
> {
> - .compatible = "rcar,medialb-dim2",
> + .compatible = "renesas,rcar-gen3-mlp",
> .data = plat_data + RCAR_M3
> },

Looks sane, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

But there is no DT binding documentation covering this block :-(

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds