Re: [PATCH v3] iio: st_sensors: don't always auto-enable I2C and SPI interface drivers

[Nikita Yushchenko]

10.01.2022 18:53, Andy Shevchenko wrote:
> On Mon, Jan 10, 2022 at 06:24:32PM +0300, Nikita Yushchenko wrote:
> > This patch makes I2C and SPI interface drivers for STMicroelectronics
> > sensor chips individually selectable via Kconfig.
> >
> > The default is kept unchanged - I2C and SPI interface drivers are still
> > selected by default if the corresponding bus support is available.
> >
> > However, the patch makes it possible to explicitly disable drivers
> > that are not needed for a particular target.
>
> ...
>
> The same question as per v2.
>
> > +	default I2C && IIO_ST_ACCEL_3AXIS
>
> What will be the results when I2C=y and the second ones =m?

$ grep CONFIG_I2C= .config
CONFIG_I2C=y
$ grep IIO_ST_ACCEL .config
CONFIG_IIO_ST_ACCEL_3AXIS=m
CONFIG_IIO_ST_ACCEL_I2C_3AXIS=m
# CONFIG_IIO_ST_ACCEL_SPI_3AXIS is not set

$ vim .config
<remove CONFIG_IIO_ST_ACCEL_I2C_3AXIS line>
$ grep IIO_ST_ACCEL .config
CONFIG_IIO_ST_ACCEL_3AXIS=m
# CONFIG_IIO_ST_ACCEL_SPI_3AXIS is not set

$ make menuconfig
<immediately exit>

$ grep IIO_ST_ACCEL .config
CONFIG_IIO_ST_ACCEL_3AXIS=m
CONFIG_IIO_ST_ACCEL_I2C_3AXIS=m
# CONFIG_IIO_ST_ACCEL_SPI_3AXIS is not set

CONFIG_IIO_ST_ACCEL_I2C_3AXIS was set to =m by default. I believe this is correct behavior.

Nikita