Re: [GIT PULL] x86/cpu for v5.17

[Linus Torvalds]

On Mon, Jan 10, 2022 at 3:16 AM Borislav Petkov <bp@xxxxxxx> wrote:
>
> - Avoid writing MSR_CSTAR on Intel due to TDX guests raising a #VE trap

This is all fine, but my reaction to this is that I would have
expected it to be either a wrmsrl_safe(), or using an actual CPU
feature check.

Checking for a particular vendor seems a bit hacky. We generally try
to avoid things like that, don't we?

Not a big deal, I just thought I'd mention it since I reacted to it.
And we don't seem to have those vendor checks in any of the other code
that uses MSR_CSTAR (just grepping for that and seeing it mentioned in
kvm code etc)

             Linus