Re: [PATCH 2/3] dt-bindings: Add dma-channels for pdma device node

[Zong Li]

On Mon, Jan 10, 2022 at 5:00 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Zong,
>
> On Wed, Jan 5, 2022 at 6:44 AM Zong Li <zong.li@xxxxxxxxxx> wrote:
> > Add dma-channels property, then we can determine how many channels there
> > by device tree, rather than statically defines it in PDMA driver
> >
> > Signed-off-by: Zong Li <zong.li@xxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml
> > +++ b/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml
> > @@ -34,12 +34,17 @@ properties:
> >      minItems: 1
> >      maxItems: 8
> >
> > +  dma-channels:
> > +    minimum: 1
> > +    maximum: 4
>
> As per my comment on [PATCH 3/3], perhaps you want to use a default
> value of 4, and document that here, too?
>

Thanks for your reminder, it should be modified as well. I would
change it and add a description in the next version.

> > +
> >    '#dma-cells':
> >      const: 1
> >
> >  required:
> >    - compatible
> >    - reg
> > +  - dma-channels
> >    - interrupts
> >    - '#dma-cells'
> >
>
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds