Re: [PATCH v3] ide: Check for null pointer after calling devm_ioremap

From: Naohiro Aota
Date: Mon Jan 10 2022 - 21:23:34 EST


On Sun, Jan 09, 2022 at 10:01:42PM +0800, Jiasheng Jiang wrote:
> On Sun, Jan 09, 2022 at 04:53:39PM +0800, Damien Le Moal wrote:
> >>>> Cc: stable@xxxxxxxxxxxxxxx#5.10
> >>>
> >>> Please keep the space before the #
> >>>
> >>> Cc: stable@xxxxxxxxxxxxxxx #5.10
> >>
> >> Actually, I added the space before, but the when I use the tool
> >> 'scripts/checkpatch.pl' to check my format, it told me a warning
> >> that it should not have space.
> >>
> >> The warning is as follow:
> >> WARNING: email address 'stable@xxxxxxxxxxxxxxx #5.10' might be
> >> better as 'stable@xxxxxxxxxxxxxxx#5.10'
> >
> > Cc: stable@xxxxxxxxxxxxxxx # 5.10
> >
> > Should work.
>
> I used 'scripts/checkpatch.pl' to check it, giving me the warning again.
>
> The warning is as follow:
> WARNING: email address 'stable@xxxxxxxxxxxxxxx # 5.10' might be better as
> 'stable@xxxxxxxxxxxxxxx# 5.10'
>
> And if I use the 'stable@xxxxxxxxxxxxxxx# 5.10', warning too.
>
> The warning is as follow:
> WARNING: email address 'stable@xxxxxxxxxxxxxxx# 5.10' might be better as
> 'stable@xxxxxxxxxxxxxxx#5.10'
>
> It seems that the only non-warning format is 'stable@xxxxxxxxxxxxxxx#5.10'.
>
> Sincerely thanks,
> Jiang
>

The checkpatch.pl in 5.10.90 fails to parse the line as shown
above. That is fixed in commit fccaebf00e60 ("checkpatch: improve
email parsing") in the current tree.