Re: [PATCH v2] scsi: pmcraid: Fix memory allocation in 'pmcraid_alloc_sglist()'

From: Martin K. Petersen
Date: Mon Jan 10 2022 - 22:01:56 EST



Christoph,

> The whole passthrough ioctl path looks completely broken to me. For
> example it dma maps the scatterlist and after that copies data to it,
> which is prohibited by the DMA API contract.
>
> So I'd be tempted to just remove the PMCRAID_PASSTHROUGH_IOCTL ioctl
> implementation entirely, and if users for it do pop up we should
> reimplement it using the proper block layer request mapping helpers.

Given that nobody has complained since 2018 I propose we remove it.

--
Martin K. Petersen Oracle Linux Engineering