Re: [PATCH 0/13] blk: make blk-rq-qos policies pluggable and modular

[Bart Van Assche]

On 1/10/22 09:36, Christoph Hellwig wrote:
> On Mon, Jan 10, 2022 at 05:10:33PM +0800, Wang Jianchao wrote:
> > This patchset attempts to make blk-rq-qos framework pluggable and modular.
>
> I really don't think making them policies modular is a good thing, and
> your new exports/APIs are a very good sign for why it is not a good
> idea.

Hi Christoph,

Personally I don't need the ability to implement blk-rq-qos 
functionality as a loadable kernel module.

When I implemented the ioprio rq-qos policy (see also blk-ioprio.c) I 
noticed that I had to make changes in the block layer core 
(blkcg_init_queue(), rq_qos_id_to_name(), blk-rq-qos.h) instead of 
having all code related to the new rq-pos policy contained in a single 
file. I think it would be an improvement if new rq-qos policies could be 
implemented in a single source file and no block layer core changes 
would be necessary.

Thanks,

Bart.