Re: [GIT PULL] Networking for 5.17

From: Linus Torvalds
Date: Mon Jan 10 2022 - 22:43:10 EST


On Mon, Jan 10, 2022 at 7:31 PM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> Merged. But I now note that this actually triggers an error when
> building with clang:
>
> net/netfilter/nf_tables_api.c:8278:4: error: variable 'data_size' is
> uninitialized when used here [-Werror,-Wuninitialized]
> data_size += sizeof(*prule) + rule->dlen;
> ^~~~~~~~~
>
> and I think clang is entirely right.

I pushed out my trivial one-liner fix for this as commit 63045bfd3c8d
("netfilter: nf_tables: don't use 'data_size' uninitialized"). The
build error kept my clang builds from working, so waiting for any
alternate fix wasn't going to happen.

Linus