RE: [Intel-wired-lan] [PATCH v4 net-next 7/9] ixgbe: pass bi->xdp to ixgbe_construct_skb_zc() directly

From: Penigalapati, Sandeep
Date: Tue Jan 11 2022 - 02:31:00 EST


>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of
>Alexander Lobakin
>Sent: Wednesday, December 8, 2021 7:37 PM
>To: intel-wired-lan@xxxxxxxxxxxxxxxx
>Cc: Song Liu <songliubraving@xxxxxx>; Jesper Dangaard Brouer
><hawk@xxxxxxxxxx>; Daniel Borkmann <daniel@xxxxxxxxxxxxx>; Yonghong
>Song <yhs@xxxxxx>; Martin KaFai Lau <kafai@xxxxxx>; John Fastabend
><john.fastabend@xxxxxxxxx>; Alexei Starovoitov <ast@xxxxxxxxxx>; Andrii
>Nakryiko <andrii@xxxxxxxxxx>; Björn Töpel <bjorn@xxxxxxxxxx>;
>netdev@xxxxxxxxxxxxxxx; Jakub Kicinski <kuba@xxxxxxxxxx>; KP Singh
><kpsingh@xxxxxxxxxx>; bpf@xxxxxxxxxxxxxxx; David S. Miller
><davem@xxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
>Subject: [Intel-wired-lan] [PATCH v4 net-next 7/9] ixgbe: pass bi->xdp to
>ixgbe_construct_skb_zc() directly
>
>To not dereference bi->xdp each time in ixgbe_construct_skb_zc(), pass bi-
>>xdp as an argument instead of bi. We can also call
>xsk_buff_free() outside of the function as well as assign bi->xdp to NULL,
>which seems to make it closer to its name.
>
>Suggested-by: Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx>
>Signed-off-by: Alexander Lobakin <alexandr.lobakin@xxxxxxxxx>
>---
> drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
Tested-by: Sandeep Penigalapati <sandeep.penigalapati@xxxxxxxxx>