Re: [PATCH] KVM: x86: Making the module parameter of vPMU more common
From: Sean Christopherson
Date: Tue Jan 11 2022 - 12:04:57 EST
Nit, s/Making/Make.
On Tue, Jan 11, 2022, Like Xu wrote:
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index c194a8cbd25f..bff2ff8cb35f 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -187,6 +187,11 @@ module_param(force_emulation_prefix, bool, S_IRUGO);
> int __read_mostly pi_inject_timer = -1;
> module_param(pi_inject_timer, bint, S_IRUGO | S_IWUSR);
>
> +/* Enable/disable PMU virtualization */
> +bool __read_mostly enable_pmu = true;
> +EXPORT_SYMBOL_GPL(enable_pmu);
> +module_param(enable_pmu, bool, 0444);
I'm definitely in favor of enable_pmu instead of pmu for the KVM, variable, but
I'd prefer we keep "pmu" for the module param, e.g. same as ept, vpid, etc...