Re: [PATCH v5] ASoC: dt-bindings: davinci-mcasp: convert McASP bindings to yaml schema

[Péter Ujfalusi]

On 1/11/22 21:21, Péter Ujfalusi wrote:
> Hi Javesh,
> 
> On 03/01/2022 09:44, Jayesh Choudhary wrote:
>> Convert the bindings for McASP controllers for TI SOCs from txt
>> to YAML schema.
>>
>> Adds additional properties 'clocks', 'clock-names', 'power-domains',
>> '#sound-dai-cells' and 'port' which were missing from the txt file.
>> Removes properties 'sram-size-playback' and 'sram-size-capture'
>> since they are not used.
>> Adds 'dmas' and 'dma-names' in the example which were missing from
>> the txt file.
>> Changes 'interrupts' and 'interrupt-names' from optional to
>> required properties.
>> Changes 'op-modes', 'serial-dir' to optional properties as they are
>> not needed if the McASP is used only as GPIO.
>> Changes 'tdm-slots' to required property only for I2S operation mode.
>>
>> Adds the yaml file in the 'MAINTAINERS' under the heading 'TEXAS
>> INSTRUMENTS ASoC DRIVERS'
> 
> I would have added description for the GPIO support as it is not obvious
> that 2 is going to be for AXR2 or 29 is for ACLKR pin.
> But I don't think this functionality is going to be used apart from the
> one dra7 evm.
> 
> Thank you for the updates and the nice work!
> 
> Acked-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx>
> 
...

>> +properties:
>> +  compatible:
>> +    enum:
>> +      - ti,dm646x-mcasp-audio
>> +      - ti,da830-mcasp-audio
>> +      - ti,am33xx-mcasp-audio
>> +      - ti,dra7-mcasp-audio
>> +      - ti,omap4-mcasp-audio

This is the only thing which bugs me: the pointless '-audio' postfix for
the compatible string...

-- 
Péter