Re: [PATCH] firmware: remove old CONFIG_FW_LOADER_MODULE test

[Luis Chamberlain]

On Tue, Jan 11, 2022 at 08:22:52PM +0100, Borislav Petkov wrote:
> On Tue, Jan 11, 2022 at 11:00:19AM -0800, Luis Chamberlain wrote:
> > Yeah I think this comes from the fact that modules get a respective
> > _MODULE define in the generated file
> > include/generated/autoconf.h 
> > 
> > For example:
> > 
> > vagrant@kdevops-dev /data/linux-next (git::20211203-umh-fix-exitcodes)$
> > grep CONFIG_CRC8 .config
> > CONFIG_CRC8=m
> > vagrant@kdevops-dev /data/linux-next (git::20211203-umh-fix-exitcodes)$
> > grep CONFIG_CRC8 include/generated/autoconf.h
> > #define CONFIG_CRC8_MODULE 1 
> > 
> > So I think the above was put in place to ask if its built-in or a
> > module.
> 
> Talk about magic:
> 
> $ grep FW_LOADER .config
> CONFIG_FW_LOADER=m
> $ grep FW_LOADER include/generated/autoconf.h 
> #define CONFIG_FW_LOADER_MODULE 1
> 
> It is probably even documented somewhere that the build generates
> CONFIG_%s_MODULE defines for testing in code...

Yeah, this is an opaque way to express this, I'll send a patch
replacement which I think which make this clearer.

  Luis