RE: [PATCH v2 01/28] pinctrl: samsung: drop pin banks references on error paths

[Chanho Park]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> Sent: Wednesday, January 12, 2022 5:14 AM
> To: Tomasz Figa <tomasz.figa@xxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxxxxx>; Sylwester Nawrocki
> <s.nawrocki@xxxxxxxxxxx>; Linus Walleij <linus.walleij@xxxxxxxxxx>; Rob
> Herring <robh+dt@xxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> samsung-soc@xxxxxxxxxxxxxxx; linux-gpio@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>; Sam Protsenko
> <semen.protsenko@xxxxxxxxxx>; Chanho Park <chanho61.park@xxxxxxxxxxx>;
> Alim Akhtar <alim.akhtar@xxxxxxxxx>; stable@xxxxxxxxxxxxxxx
> Subject: [PATCH v2 01/28] pinctrl: samsung: drop pin banks references on
> error paths
> 
> The driver iterates over its devicetree children with
> for_each_child_of_node() and stores for later found node pointer.  This
> has to be put in error paths to avoid leak during re-probing.
> 
> Fixes: ab663789d697 ("pinctrl: samsung: Match pin banks with their device
> nodes")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>

Reviewed-by: Chanho Park <chanho61.park@xxxxxxxxxxx>

Best Regards,
Chanho Park