Re: [PATCH v4 1/1] ucsi_ccg: Check DEV_INT bit only when starting CCG4

[Wayne Chang]

On 1/12/22 5:09 PM, Heikki Krogerus wrote:
> 
> 
> On Wed, Jan 12, 2022 at 08:41:50AM +0000, Wayne Chang wrote:
>> Hi Heikki
>>
>> Thanks for the review.
>>
>> On 1/12/22 3:50 PM, Heikki Krogerus wrote:
>>>
>>>
>>> Hi,
>>>
>>> On Wed, Jan 12, 2022 at 01:49:50PM +0800, Wayne Chang wrote:
>>>> From: Sing-Han Chen <singhanc@xxxxxxxxxx>
>>>>
>>>> after driver sending the UCSI_START cmd, CCGx would
>>>> clear Bit 0:Device Interrupt in the INTR_REG if CCGX
>>>> reset successfully.
>>>>
>>>> however, there might be a chance that other bits in
>>>> INTR_REG are not cleared due to internal data queued
>>>> in PPM and cause the driver thinks CCGx reset failed.
>>>>
>>>> the commit checks bit 0 in INTR_REG and ignore other
>>>> bits. ucsi driver would reset PPM later.
>>>>
>>>> Fixes: 247c554a14aa ("usb: typec: ucsi: add support for Cypress CCGx")
>>>
>>> So... no need to take this to the stable kernel releases?
>>>
>> Should I put cc tag here?
> 
> Yes, Cc: stable@xxxxxxxxxx, unless you have some good reason not to.
> I'm guessing you don't. This stuff is also explained here:
> 
> https://docs.kernel.org/process/submitting-patches.html#select-the-recipients-for-your-patch
> 
Thanks for the information. I'll add the Cc tag in the next version.

>>>> Signed-off-by: Sing-Han Chen <singhanc@xxxxxxxxxx>
>>>> Signed-off-by: Wayne Chang <waynec@xxxxxxxxxx>
>>>> ---
>>>
>>> What has changed since v3 (and v2) - there is no patch changelog here?
>>>
>>> In case this is new to you, you list those changes under that '---'
>>> line so they don't become part of the permanent changelog:
>>>
>>> https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format
>>>
>> The changes are resent for updating the commit messages.
>> Added the Fixes tag which Greg asked for.
>> Thanks for information. I went through the documents.
>> Should I put the following messages in the patch after "---" or should I use resend in subject
>> for the commit messages updated?
>> v3 -> v4 commit messages updated
> 
> I think you can say exactly what you did, like "Added the Fixes tag"
> or whatever you did.
> 
>> v2 -> v3 commit messages updated
> 
> Ditto.
> 
>> v1 -> v2 commit messages updated
> 
> Ditto.
> 
> Since you are going to do one more version of this, could you also
> start the sentences with upper-case letters in the commit message?
> Normally I'm not very picky about the grammar stuff (I make plenty of
> mistakes myself), but this time it's driving me crazy for some reason.
> 
Sure, I'll also minimize the words in a sentence and make it readable.
Thanks for the advice.
> thanks,
> 
> --
> heikki
> 

thanks,
Wayne.