Re: [PATCH] nvme: Mark external NVMe devices as removable

[Kai-Heng Feng]

On Wed, Jan 12, 2022 at 3:17 PM Christoph Hellwig <hch@xxxxxx> wrote:
>
> On Wed, Jan 12, 2022 at 09:31:54AM +0800, Kai-Heng Feng wrote:
> > Commit c037b6c818c3 ("PCI: Add sysfs "removable" attribute") can mark
> > entire Thunderbolt hierarchy as removable, if system firmware provides
> > correct attribute.
> >
> > So apply GENHD_FL_REMOVABLE for NVMe if removable bit is set, to make
> > userspace daemon like Udisks knows it can be automount.
>
> GENHD_FL_REMOVABLE means removable media as in floppies or CD-ROMs,
> which does not apply to NVMe at all.

USB thumb drives also use this flag, so I am not sure why it's not
applicable to NVMe?

Kai-Heng