Re: [PATCH v1 1/1] gpio: tegra: Get rid of duplicate of_node assignment
From: Thierry Reding
Date: Wed Jan 12 2022 - 08:11:59 EST
On Thu, Dec 23, 2021 at 02:26:39PM +0200, Andy Shevchenko wrote:
> GPIO library does copy the of_node from the parent device of
> the GPIO chip, there is no need to repeat this in the individual
> drivers. Remove these assignment all at once.
>
> For the details one may look into the of_gpio_dev_init() implementation.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/gpio/gpio-tegra.c | 1 -
> 1 file changed, 1 deletion(-)
Yep, this is indeed not necessary (anymore), so:
Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
I've also given this a quick spin on a Tegra124 device (Venice 2) and
everything seems to be working fine, so also:
Tested-by: Thierry Reding <treding@xxxxxxxxxx>
Thanks,
Thierry
Attachment:
signature.asc
Description: PGP signature