Re: [PATCH] drivers/acpi/apei: remove redundant rc variable

[Rafael J. Wysocki]

On Wed, Jan 12, 2022 at 9:02 AM <cgel.zte@xxxxxxxxx> wrote:
>
> From: Minghao Chi <chi.minghao@xxxxxxxxxx>
>
> Return value from apei_exec_write_register() directly instead
> of taking this in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Minghao Chi <chi.minghao@xxxxxxxxxx>
> Signed-off-by: CGEL ZTE <cgel.zte@xxxxxxxxx>

Well, this doesn't look like an e-mail address of a physical person
which is required for S-o-b tags.

> ---
>  drivers/acpi/apei/apei-base.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/apei/apei-base.c b/drivers/acpi/apei/apei-base.c
> index c7fdb12c3310..87145b6b89aa 100644
> --- a/drivers/acpi/apei/apei-base.c
> +++ b/drivers/acpi/apei/apei-base.c
> @@ -125,12 +125,9 @@ EXPORT_SYMBOL_GPL(apei_exec_write_register);
>  int apei_exec_write_register_value(struct apei_exec_context *ctx,
>                                    struct acpi_whea_header *entry)
>  {
> -       int rc;
> -
>         ctx->value = entry->value;
> -       rc = apei_exec_write_register(ctx, entry);
> +       return apei_exec_write_register(ctx, entry);
>
> -       return rc;
>  }
>  EXPORT_SYMBOL_GPL(apei_exec_write_register_value);
>
> --
> 2.25.1
>