Re: [PATCHv2 3/7] efi/x86: Implement support for unaccepted memory
From: Dave Hansen
Date: Wed Jan 12 2022 - 14:36:19 EST
On 1/12/22 11:29 AM, Kirill A. Shutemov wrote:
>>> + * In the worst case scenario -- a huge hole in the middle of the
>>> + * address space -- It needs 256MiB to handle 4PiB of the address
>>> + * space.
>>> + *
>>> + * TODO: handle situation if params->unaccepted_memory has already set.
>>> + * It's required to deal with kexec.
>> What happens today with kexec() since its not dealt with?
> I didn't give it a try, but I assume it will hang.
>
> There are more things to do to make kexec working and safe. We will get
> there, but it is not top priority.
Well, if we know it's broken, shouldn't we at least turn kexec off?
It would be dirt simple to do in Kconfig. As would setting:
kexec_load_disabled = true;
which would probably also do the trick. That's from three seconds of
looking. I'm sure you can come up with something better.