Re: [PATCH v5 01/13] dt-bindings: Add generic bindings for PECI

[Joel Stanley]

On Wed, 12 Jan 2022 at 23:03, Iwona Winiarska <iwona.winiarska@xxxxxxxxx> wrote:
>
> Add device tree bindings for the PECI controller.
>
> Signed-off-by: Iwona Winiarska <iwona.winiarska@xxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

Reviewed-by: Joel Stanley <joel@xxxxxxxxx>

> ---
>  .../bindings/peci/peci-controller.yaml        | 33 +++++++++++++++++++
>  1 file changed, 33 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/peci/peci-controller.yaml
>
> diff --git a/Documentation/devicetree/bindings/peci/peci-controller.yaml b/Documentation/devicetree/bindings/peci/peci-controller.yaml
> new file mode 100644
> index 000000000000..bbc3d3f3a929
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/peci/peci-controller.yaml
> @@ -0,0 +1,33 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/peci/peci-controller.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Generic Device Tree Bindings for PECI
> +
> +maintainers:
> +  - Iwona Winiarska <iwona.winiarska@xxxxxxxxx>
> +
> +description:
> +  PECI (Platform Environment Control Interface) is an interface that provides a
> +  communication channel from Intel processors and chipset components to external
> +  monitoring or control devices.
> +
> +properties:
> +  $nodename:
> +    pattern: "^peci-controller(@.*)?$"
> +
> +  cmd-timeout-ms:
> +    description:
> +      Command timeout in units of ms.
> +
> +additionalProperties: true
> +
> +examples:
> +  - |
> +    peci-controller@1e78b000 {
> +      reg = <0x1e78b000 0x100>;
> +      cmd-timeout-ms = <500>;
> +    };
> +...
> --
> 2.31.1
>