Re: [PATCH v4 06/15] KVM: arm64: Add paravirtualization header files

[Gavin Shan]

Hi Eric,

On 11/11/21 2:06 AM, Eric Auger wrote:
> On 8/15/21 2:59 AM, Gavin Shan wrote:
> > We need put more stuff in the paravirtualization header files when
> > the asynchronous page fault is supported. The generic header files
> > can't meet the goal.
> you need to explain why
>   This duplicate the generic header files to be
> s/This duplicate/Duplicate

Ok.

> > our platform specific header files. It's the preparatory work to
> > support the asynchronous page fault in the subsequent patches:
> why duplication and not move. Shouldn't it be squashed with another
> subsequent patch?

It's also fine to squash this one to PATCH[v4 07/15]. My intent was
to keep them separate to make PATCH[v4 07/17] a bit easier to be
reviewed. So lets keep it as separate patch :)

> >     include/uapi/asm-generic/kvm_para.h
> >     include/asm-generic/kvm_para.h
> >
> >     arch/arm64/include/uapi/asm/kvm_para.h
> >     arch/arm64/include/asm/kvm_para.h
> >
> > Signed-off-by: Gavin Shan <gshan@xxxxxxxxxx>
> > ---
> >   arch/arm64/include/asm/kvm_para.h      | 27 ++++++++++++++++++++++++++
> >   arch/arm64/include/uapi/asm/Kbuild     |  2 --
> >   arch/arm64/include/uapi/asm/kvm_para.h |  5 +++++
> >   3 files changed, 32 insertions(+), 2 deletions(-)
> >   create mode 100644 arch/arm64/include/asm/kvm_para.h
> >   create mode 100644 arch/arm64/include/uapi/asm/kvm_para.h
> >
> > diff --git a/arch/arm64/include/asm/kvm_para.h b/arch/arm64/include/asm/kvm_para.h
> > new file mode 100644
> > index 000000000000..0ea481dd1c7a
> > --- /dev/null
> > +++ b/arch/arm64/include/asm/kvm_para.h
> > @@ -0,0 +1,27 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +#ifndef _ASM_ARM_KVM_PARA_H
> > +#define _ASM_ARM_KVM_PARA_H
> > +
> > +#include <uapi/asm/kvm_para.h>
> > +
> > +static inline bool kvm_check_and_clear_guest_paused(void)
> > +{
> > +	return false;
> > +}
> > +
> > +static inline unsigned int kvm_arch_para_features(void)
> > +{
> > +	return 0;
> > +}
> > +
> > +static inline unsigned int kvm_arch_para_hints(void)
> > +{
> > +	return 0;
> > +}
> > +
> > +static inline bool kvm_para_available(void)
> > +{
> > +	return false;
> > +}
> > +
> > +#endif /* _ASM_ARM_KVM_PARA_H */
> > diff --git a/arch/arm64/include/uapi/asm/Kbuild b/arch/arm64/include/uapi/asm/Kbuild
> > index 602d137932dc..f66554cd5c45 100644
> > --- a/arch/arm64/include/uapi/asm/Kbuild
> > +++ b/arch/arm64/include/uapi/asm/Kbuild
> > @@ -1,3 +1 @@
> >   # SPDX-License-Identifier: GPL-2.0
> > -
> > -generic-y += kvm_para.h
> > diff --git a/arch/arm64/include/uapi/asm/kvm_para.h b/arch/arm64/include/uapi/asm/kvm_para.h
> > new file mode 100644
> > index 000000000000..cd212282b90c
> > --- /dev/null
> > +++ b/arch/arm64/include/uapi/asm/kvm_para.h
> > @@ -0,0 +1,5 @@
> > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> > +#ifndef _UAPI_ASM_ARM_KVM_PARA_H
> > +#define _UAPI_ASM_ARM_KVM_PARA_H
> > +
> > +#endif /* _UAPI_ASM_ARM_KVM_PARA_H */

Thanks,
Gavin