Re: [PATCH] i2c: piix4: Replace piix4_smbus driver's cd6h/cd7h port io accesses with mmio accesses

From: Andy Shevchenko
Date: Thu Jan 13 2022 - 05:26:53 EST


On Thu, Jan 13, 2022 at 9:42 AM Wolfram Sang <wsa@xxxxxxxxxx> wrote:
>
>
> > > On top of that I'm wondering why slow I/O is used? Do we have anything
> > > that really needs that or is it simply a cargo-cult?
> >
> > The efch SMBUS & WDT previously only supported a port I/O interface
> > (until recently) and thus dictated the HW access method.
>
> Is this enough information to start v2 of this series? Or does the
> approach need more discussion?

I dunno why slow I/O is chosen, but it only affects design (read:
ugliness) of the new code.

--
With Best Regards,
Andy Shevchenko